Eclipse integration #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riordanp
approved these changes
Nov 6, 2024
godmodegalactus
force-pushed
the
eclipse_integration
branch
from
ce882d9 to
4a7d092
Compare
mschneider
reviewed
Nov 6, 2024
| refresh_interval_secs = 1200 # every 20 min | ||
|
|
||
| [safety_checks] | ||
| check_quote_out_amount_deviation = true |
mschneider
reviewed
Nov 6, 2024
| .await? | ||
| .1, | ||
| ) | ||
| let disable_compressed = std::env::var::<String>("DISABLE_COMRPESSED_GPA".to_string()) |
There was a problem hiding this comment.
this should be a config variable in RpcProgramAccountsConfig not an env variable
There was a problem hiding this comment.
This method is used only in the smoke tests, tests do not use RpcProgramAccountsConfig. So no use of removing this env variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.